Plot single value group #53
Conversation
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #53 +/- ##
==========================================
+ Coverage 83.10% 83.13% +0.03%
==========================================
Files 4 4
Lines 1095 1097 +2
==========================================
+ Hits 910 912 +2
Misses 185 185
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Changes requested to replace dplyr usage with data.table: https://github.com/certara/tidyvpc/pull/53/files#r1326571356
R/plot.R
Outdated
| #' single-value groups | ||
| #' @noRd | ||
| expand_vpc_stats_single_value <- function(vpc, xvar, width = 0.0001) { | ||
| d_vpc_stats <- vpc$strat |
There was a problem hiding this comment.
@certara-jcraig Ah, this line should be vpc$stats not vpc$strat
There was a problem hiding this comment.
That makes a lot more sense! Updated dplyr commands to data.table.
| expand_vpc_stats_single_value <- function(vpc, xvar, width = 0.0001) { | ||
| d_vpc_stats <- vpc$stats | ||
| if (!is.null(vpc$strat)) { | ||
| d_vpc_stats[, n_xvar := length(unique(get(xvar))), by = names(vpc$strat)] |
There was a problem hiding this comment.
Note that with data.table, we can modify d_vpc_stats directly, adding or updating the n_xvar column, without needing to reassign it with d_vpc_stats <- ...
Ensure that plotting shows up for single-value groups (related to #51)
This should be applied on top of #52 (review that one first)
Check the added test to see this visually. Generally, I ensured that the x-values were slightly lower and higher than the original values so that lines and ribbons showed up.